feat(codex): publish verified routed service tiers - #1521
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⏳ DRAFT
What to do
Review readiness checklist
1/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
The implementation and focused verification are green. The only blocked gate is the repository security-boundary rule because this PR touches |
3425900 to
e12d917
Compare
|
Rebased onto current |
e12d917 to
15e1734
Compare
|
Rebased and force-with-lease pushed onto current dev@cbbfdd8773e68a5dc2391ddeb32f33a225373c1a; new head is 15e1734. Fresh local proof: capability/catalog/runtime focused suite 309/309, 1167 assertions; typecheck, privacy scan, and diff check passed. The only remaining repository gate is maintainer sponsorship for the narrow provider-management validation/public DTO change in src/server/auth-cors.ts; I am leaving the PR Draft and will not bypass that security-boundary rule. |
|
The security-boundary gate is now addressed by a real scope split, not by weakening validation: commit moves the new service-tier validation and public DTO projection into , removes the two additions from , and keeps POST/PATCH validation plus projection behavior intact. The diff no longer changes the protected auth-cors file. Fresh proof after the split: capability management projection/validation and persistence tests pass; related catalog/runtime/Chat tests 229/229; typecheck, privacy scan, and diff check pass. Please let hygiene/enforce-target rerun and review the new management-only module. |
|
The security-boundary gate is now addressed by a real scope split, not by weakening validation: commit Fresh proof after the split: capability management projection/validation and persistence tests pass; related catalog/runtime/Chat tests 229/229; typecheck, privacy scan, and diff check pass. Please let hygiene/enforce-target rerun and review the new management-only module. |
|
Initial maintainer review on exact head The scope split out of I am keeping this draft pending deeper review and executed exact-head CI. Please do not merge yet. The next review must verify at least these boundaries:
If those checks hold on current |
|
Updated exact head: The runtime follow-up now uses the same final model/wire capability decision as catalog projection: explicit caller tiers are preserved only when the final adapter can forward them, and stripped fail-closed for provider/model denial or a non-service-tier adapter. Provider-level false remains authoritative. Fresh local proof on this exact head: 230 focused catalog/runtime/Chat tests passed, 879 assertions; management scope-split proof was 2 tests/26 assertions; typecheck, privacy scan, diff check, and the 265-page docs build passed. The PR remains Draft for exact-head CI and the requested maintainer review. |
c6c0c98 to
fcd9126
Compare
|
Superseded by the final current-dev update below. The authoritative candidate is now based on |
fcd9126 to
2a9c48d
Compare
|
Final current-dev rebase completed after correcting the upstream base pointer. Base: |
2a9c48d to
7782d82
Compare
|
Current exact-head handoff: rebased onto upstream Post-rebase proof: service-tier/OpenAI focused tests 56 passed, 0 failed, 100 assertions; typecheck, privacy scan, and diff check passed. Please run exact-head CI and the six requested capability-boundary checks; keeping Draft. |
7782d82 to
1ed3788
Compare
|
Final exact-head update: upstream The final rebase proof is 56/56 service-tier/OpenAI tests, 100 assertions, plus typecheck, privacy scan, and diff check. Please review the six capability boundaries and run exact-head CI; Draft remains intentional. |
|
Final exact-head gate status: |
|
@lidge-jun Reviewer-request API is unavailable to the fork author (403), so this is the explicit handoff instead. Final head |
1ed3788 to
b1bebc0
Compare
|
Current exact-head handoff after the latest upstream rebase:
The PR remains Draft because the requested independent maintainer review and readiness confirmation are still pending. Please review this exact head against the six capability boundaries listed in the earlier review; #1512 remains the fallback until this candidate is accepted. |
Summary
service_tierfield.falseauthoritative over exact-modeltrue; retain exact provider-scoped resolution in catalog metadata, combo intersections, custom-model projection, and management validation/DTO projection.auth-cors.tsscope split remains intact; the final runtime gate is isolated in the Responses normalization path.dev@567a6d4ffe6a7d7b341b5cc11e736081e1bb4522; current head:b1bebc059482f06b9e1e8be3aeaf2bb7902b1685.Refs #1436
Refs #1504
Refs #1512
Verification
tests/service-tier-capability.test.ts.tests/codex-catalog.test.ts.tests/management-provider-validation.test.ts.bun test --isolate --max-concurrency 1 --timeout 15000 tests/service-tier-capability.test.ts tests/openai-chat-hardening.test.ts— 56 passed, 0 failed, 100 assertions after rebase.bun run typecheck— passed.bun run privacy:scan— passed.git diff --check origin/dev...HEAD— passed.dev.Checklist
dev.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met: